credstash-grant-reader could not be planned with empty(default) context_keys and context_values

fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform

MIT License

204 stars 98 forks source link

credstash-grant-reader could not be planned with empty(default) context_keys and context_values #265

Open Magicloud opened 4 years ago

Magicloud commented 4 years ago

Checking out the code, this line looks weird to me. https://github.com/fpco/terraform-aws-foundation/blob/d15768b3499638bba76c878e83659faa71741876/modules/credstash-grant-reader/main.tf#L54

Seems like I must pass one and only one key/value pair for each role. Wondering if this code was not as it supposed to be.

ketzacoatl commented 4 years ago

@Magicloud can you clarify: how can we help, or what would you like to see done?

Magicloud commented 4 years ago

@ketzacoatl This was the confusing code piece I chatted with you the other day. I think it is a mis-implementation. Thus I have that PR. Please review.