search

fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 97 forks source link

Credstash grant #266

Open Magicloud opened 5 years ago

Magicloud commented 5 years ago

Passed mock data planning. Fixes #265.

ketzacoatl commented 4 years ago

Should we also drop role_count and refactor/cleanup those variables all the way?

cc @Magicloud / @qrilka

qrilka commented 4 years ago

@ketzacoatl yes, that was one of my proposals, just put it into a list of objects with names and ARNs. The current approach is quite awkward and error prone

Magicloud commented 4 years ago

I am with removing "role_count". But seeing that comment, "circumvent issue", the issue is still open (for a few years....). @ketzacoatl Is that issue fixed or unrelated now, especially we are on 0.12 now.

ketzacoatl commented 4 years ago

@Magicloud what are next steps for this PR?