fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 98 forks source link

asg module: Default value for variable key_name #269

Closed psibi closed 4 years ago

psibi commented 4 years ago

The default value is an empty string which indicates the instance in the ASG has no key associated with it. This makes the key to be optionally passed when using the module.

Please also note that these are not hard requirements, but merely serve to define what maintainers are looking for in PR's. Including these will more likely lead to your PR being reviewed and accepted.

ketzacoatl commented 4 years ago

I believe we don't have a default value here b/c we want to force the module user to define that parameter, and in doing so, we also ensure they are explicit in the case when there is no key (which is not common unless using windows).

psibi commented 4 years ago

Fair point!