search

fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 98 forks source link

Remove deprecated interpolation-only exprs from tf-cloud-credential #278

Closed qrilka closed 4 years ago

qrilka commented 4 years ago

This is more or less trivial fix and it will remove a lot of deprecation warnings in our terraform runs

qrilka commented 4 years ago

@ketzacoatl how could I trigger CI?

ketzacoatl commented 4 years ago

This is more or less trivial fix and it will remove a lot of deprecation warnings in our terraform runs

Yea, LGTM.

how could I trigger CI?

If the module has been added to tests/main.tf, pushing commits to a branch is all that should be needed.

ketzacoatl commented 4 years ago

I believe I have added this module to the test suite, and the test suite is still green/passing (https://gitlab.fpcomplete.com/fpco-mirrors/terraform-aws-foundation/-/jobs/22949), but the script doesn't list the modules initialized/tested, so I'm unable to validate that I've added this module.