fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
203 stars 99 forks source link

Asg root device encryption #285

Closed qrilka closed 4 years ago

qrilka commented 4 years ago

Please include the following in your PR:

Please also note that these are not hard requirements, but merely serve to define what maintainers are looking for in PR's. Including these will more likely lead to your PR being reviewed and accepted.

This follows #283 adding root encryption.

qrilka commented 4 years ago

Sample plan:

      ~ root_block_device {
            delete_on_termination = true
          ~ encrypted             = false -> true # forces replacement
          ~ iops                  = 0 -> (known after apply)
            volume_size           = 40
            volume_type           = "gp2"
        }

And AWS console shows root device as encrypted

ketzacoatl commented 4 years ago

Seems like we should also update the asg module's README.md - https://github.com/fpco/terraform-aws-foundation/blob/asg-root-device-encryption/modules/asg/README.md

qrilka commented 4 years ago

But we don't list all the available options - do we really need to say about root device encryption when we don't even say that we support root device size and type?

qrilka commented 4 years ago

@ketzacoatl I've rebased this PR onto #283 and updated README so that one should be merged first