search

fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 98 forks source link

s3-remote-state.principals should not have empty list as default. #286

Closed Magicloud closed 4 years ago

Magicloud commented 4 years ago

Default value means the caller can skip that variable, but skipping that value ends up invalid policy document passing to AWS and terraform stuck on creating the policy.

The default value should be gone to inform the caller that he must pass a value.

mcgirr commented 4 years ago

I have https://github.com/fpco/terraform-aws-foundation/pull/297 for this issue

mcgirr commented 4 years ago

This issue has been completed now with https://github.com/fpco/terraform-aws-foundation/pull/297