fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
203 stars 99 forks source link

module/init-snippet-attach-ebs-volume: Manually make device name for attached EBS volume. #291

Open Magicloud opened 4 years ago

Magicloud commented 4 years ago

Due to Linux kernel and Distro changes, an attched EBS volume may not get the specified device name (Ref https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html). Hence logic following may break since specified device does not exist.

This change uses Linux trick to manually setup (if it has not) the device name, so other logic can be static, without guessing which device is it.


name: Pull request template about: Make a PR to terraform-aws-foundation

Please include the following in your PR:

Please also note that these are not hard requirements, but merely serve to define what maintainers are looking for in PR's. Including these will more likely lead to your PR being reviewed and accepted.

ketzacoatl commented 4 years ago

@Magicloud what are next steps for this PR?