search

fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
203 stars 99 forks source link

Have the alb_target_group_arns passed through to the asg module used in the single node asg module #316

Closed mcgirr closed 4 years ago

mcgirr commented 4 years ago

We don't have the alb_target_group_arns being passed through to the asg module that is being used in the single node asg module here: https://github.com/fpco/terraform-aws-foundation/blob/d4daaa2af8d2338c0e17afa3921cde39de838f76/modules/single-node-asg/main.tf#L55-L57

And I think we'd like to have that be able to optionally take an input for the alb_target_group_arns variable from the asg module so it can make use of https://github.com/fpco/terraform-aws-foundation/blob/d4daaa2af8d2338c0e17afa3921cde39de838f76/modules/asg/main.tf#L114-L119

This would mean that we don't have to add aws_autoscaling_attachment resources when we use the single node ASG module since like I said we're already doing that under the hood now with the asg module (now that https://github.com/fpco/terraform-aws-foundation/pull/296 has been merged).

mcgirr commented 4 years ago

I've opened https://github.com/fpco/terraform-aws-foundation/pull/317 with the changes for this issue.