Pass the alb_target_group_arns to the ASG in the SNASG module

fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform

MIT License

203 stars 99 forks source link

Pass the alb_target_group_arns to the ASG in the SNASG module #317

Closed mcgirr closed 4 years ago

mcgirr commented 4 years ago

Closes https://github.com/fpco/terraform-aws-foundation/issues/316

mcgirr commented 4 years ago

Okay will do!

ketzacoatl commented 4 years ago

ping

mcgirr commented 4 years ago

I've added a basic example to this PR in the the examples directory. The code in that uses the changes made for this PR to the single node autoscaling group.

The example is able to plan and apply

Apply complete! Resources: 24 added, 0 changed, 0 destroyed.

mcgirr commented 4 years ago

@ketzacoatl Please let me know if that's enough validation for this or if you'd prefer to have more output from that. I can update the CHANGELOG after we merge this to mention the changes to the SNASG module as well as the new example.