fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 98 forks source link

r53-subdomain: vpc block should be dyanamic, for when zone is public #330

Open ketzacoatl opened 3 years ago

ketzacoatl commented 3 years ago

This update uses dynamic blocks from Terraform 0.12 to allow the r53-subdomain module to work with both private and public zones. With Terraform 0.11, an empty vpc_id would not error out but with 0.12, the vpc block should not exist if the vpc_id param would be empty.