search

fpco / unliftio

The MonadUnliftIO typeclass for unlifting monads to IO
Other
151 stars 51 forks source link

Remove default implementation for `withRunInIO` #56

Closed akrmn closed 4 years ago

akrmn commented 4 years ago

Forgot to mention, a consequence of #55 is that this default implementation will make withRunInIO loop through askUnliftIO for people who define an empty instance (or who derive anyclass).

https://github.com/fpco/unliftio/blob/d9946e6907289e222f078c26563758bcf6ffb7d9/unliftio-core/src/Control/Monad/IO/Unlift.hs#L60-L62

snoyberg commented 4 years ago

Good catch, thanks! That was a stupid mistake on my part. Releasing a fix shortly.