Add success and error messages to the ajax responses

[smcalilly]

Overview

Closes:

• 114

Notes

We might want to improve the success messages when the page reloads. The message shows up and the page reloads, which kinda seems like the action is done, but the page is still reloading and we don't want users to use the page during that. Maybe adding the success message near the "save asset" button, plus giving a loading indicator would be more helpful...thoughts?

Testing Instructions

• review app: https://ccfp-asset-d-ajax-messa-ukywag.herokuapp.com
• test credentials are called "ccfp-asset-dashboard test user"
• search. turn off your wifi network and see an error message.
• select/save an asset. see success message. select/save again with network turned off, see error message.
• delete an asset. see messages etc

[smcalilly]

What if you saved that message to the session and check for messages when the page loads, clearing them from the session after they're rendered?

@hancush do you know of any DataMade examples that do this? I'm having a hard time finding the best way to do this. This is the best I can find in SO. I'm not sure the best way to access the session in a generic view?

Perhaps for successful responses, we can do something similar to what you're doing in the CIP planner, instead of using a message-like thing in the template? Like how you're showing that the portfolio saved where the button is. And then for error messages, we can show the message in the Django template, since that seems natural and isn't dependent on a page reload.

[hancush]

That would work, @smcalilly! I like the pragmatism.

[smcalilly]

@hancush I made these changes:

• after saving assets, show success message in the button
• after deleting assets, show a success message above the table. show an error message above that table too — the previous code showed the message at the top of the page and i thought that was not helpful because you can't see it unless you scroll up.

[smcalilly]

@hancush I made the requested changes. I'm not sure how to render the message only after it reloads since adding that to state will show the component. Do you have any ideas, or is this ok as is?

Add and delete some assets to see it in action: https://ccfp-asset-d-ajax-messa-ukywag.herokuapp.com/projects/phases/edit/4/assets/