set score_field_value as 0 instead of returning 0 as the total score - Githubissues

fpdcc / ccfp-asset-dashboard

CCFP Asset Dashboard

0 stars 1 forks source link

set score_field_value as 0 instead of returning 0 as the total score #211

Closed smcalilly closed 2 years ago

smcalilly commented 2 years ago

Overview

Closes #208

Notes

This change:

defaults all the project score fields when a project is created
adds a signal to set geographic_distance_score and social_equity_score to 5 when the project is countywide

Testing Instructions

visit review app: https://ccfp-asset-d-patch-scor-fafe7c.herokuapp.com
create a project
change the scores
confirm that the score changes even if there are no gis assets connected to the project

to test the countywide change:

create a phase
set the project as countywide
confirm the score updates in the project detail view

fgregg commented 2 years ago

i think we should count as 5

smcalilly commented 2 years ago

@fgregg i set the geo scores as 5 when the project is countywide.

i edited this PR description with the changes — will you please re-review?