fpdcc / ccfp-asset-dashboard

CCFP Asset Dashboard
0 stars 1 forks source link

production - check redirect links when "items" are deleted #217

Closed glw closed 1 year ago

glw commented 1 year ago

There has been anecdotal mentions that after deleting of phase funding the redirect to the wrong project page. So when removing/deleting "items" (phases, phase funding, etc.) links to redirect users should be double checked.

smcalilly commented 1 year ago

@xmedr For this issue, my suspicion is that the redirect url is being created based on the id of the item that is deleted instead of the id of the project.

So like, the urls might look like this:

Whenever a user "deletes" the phase or phase funding, what key is used to build the redirect url? It should be the project key (85 in the above project url example). You might need to hook into the PhaseDeleteView and the FundingStreamDeleteView to set the correct id in the redirect url.

smcalilly commented 1 year ago

We're not able to recreate this. Is it possible that this is a duplicate issue @glw? We've dealt with this in the past and fixed via this issue #137. Also related to PR #216.

smcalilly commented 1 year ago

We couldn't recreate this. @xmedr wrote tests in PR #229 to confirm that users are redirected to the correct page after deleting.