Flatten CIP tables based on phase funding streams + add more data to CIP export

fpdcc / ccfp-asset-dashboard

CCFP Asset Dashboard

0 stars 1 forks source link

Flatten CIP tables based on phase funding streams + add more data to CIP export #270

Closed smcalilly closed 10 months ago

smcalilly commented 10 months ago

Overview

related to #257, but doesn't close it. This first step of flattening the data is needed in order to add the filters.
closes #219

Testing Instructions

visit the cip planner: https://ccfp-asset-d-feature-fl-3knsmw.herokuapp.com/
- login with username=test / password=supersecret
build a portfolio. see how the columns are different and the phase funding stream make each row unique
export the portfolio and make sure the data looks right

smcalilly commented 10 months ago

@xmedr thanks for digging into that bug. I'll see if my code change created this. If not, we can address it in a separate PR.

It had the items I had added, but also some extras that I couldn't find in either table

This might be expected but I'm not sure without seeing your export. There are several key/values in the data that we aren't showing in the tables but are still connected to each row. Then we do some extra processing to add the cost by zone and separate the asset types into their own columns.

smcalilly commented 10 months ago

@xmedr i fixed that bug. can you please review again?

smcalilly commented 10 months ago

@xmedr thanks for your QA. i fixed that. lemme know if you find any other issues.