Integrate Accessible Amenities (fishing areas, canoe landings, boat launches, campsites)

[versatilehuman]

• [x] New Columns
• [x] Panel
• [x] Map Icons for New Activities

New Columns

activities

• accessible
  • boolean

points_of_interest

• accessible_canoe
  • boolean
• accessible_fishing
  • boolean
• accessible_campsite
  • boolean
• accessible_boat
  • boolean

Based on data updates: https://github.com/fpdcc/webmap_data_updates/issues/242 & https://github.com/fpdcc/webmap_data_updates/issues/239

For here? https://github.com/fpdcc/trailsyserver/blob/development/db/schema.rb

Panel

Javascript

Add after this: https://github.com/fpdcc/trailsy/blob/development/js/panelFunctions.js#L557 (after Canoe Landing)

// accessible_canoe = Accessible Canoe
        if (poi.properties.tags[':panel'].indexOf('accessible_canoe') > -1) {
          fpccAmenitiesString += "<div class='fpccAmenity'><svg class='icon icon-canoe-landing-accessible'><use xlink:href='icons/defs.svg#icon-canoe-landing-accessible'></use></svg><span class='fpccAmenityTitle'><a href='https://fpdcc.com/things-to-do/boating-canoeing-kayaking/'>Accessible Canoe Landing</a></span></div>"
        }

Add after this: https://github.com/fpdcc/trailsy/blob/development/js/panelFunctions.js#L524 (after Boat Launch)

// accessible_boat = Accessible Boat
        if (poi.properties.tags[':panel'].indexOf('accessible_boat') > -1) {
          fpccAmenitiesString += "<div class='fpccAmenity'><svg class='icon icon-boat-launch-accessible'><use xlink:href='icons/defs.svg#icon-boat-launch-accessible'></use></svg><span class='fpccAmenityTitle'><a href='https://fpdcc.com/things-to-do/boating-canoeing-kayaking/'>Accessible Boat Launch</a></span></div>"
        }

Add after this: https://github.com/fpdcc/trailsy/blob/development/js/panelFunctions.js#L553 (after Camp Store)

// accessible_campsite = Accessible Campsites
        if (poi.properties.tags[':panel'].indexOf('accessible_campsite') > -1) {
          fpccAmenitiesString += "<div class='fpccAmenity'><svg class='icon icon-camp-accessible'><use xlink:href='icons/defs.svg#icon-camp-accessible'></use></svg><span class='fpccAmenityTitle'><a href='https://fpdcc.com/things-to-do/camping/'>Accessible Campsites</a></span></div>"
        }

Add after this: https://github.com/fpdcc/trailsy/blob/development/js/panelFunctions.js#L689 (after Ice Fishing)

// accessible_fishing = Accessible Fishing Area
        if (poi.properties.tags[':panel'].indexOf('accessible_fishing') > -1) {
          fpccAmenitiesString += "<div class='fpccAmenity'><svg class='icon icon-fishing-accessible'><use xlink:href='icons/defs.svg#icon-fishing-accessible'></use></svg><span class='fpccAmenityTitle'><a href='https://fpdcc.com/things-to-do/fishing/'>Accessible Fishing Areas</a></span></div>"
        }

SVG

In updated defs.svg https://github.com/fpdcc/trailsy/commit/056d1f3229fe6b9b8daa47b9636ae44d571cb6c5

CSS

Updated in newguts.css https://github.com/fpdcc/trailsy/commit/48e4ea0a23bc852a1878dd95dac67e3fa4b08e8f

Map Icons for New Activities

Building activities on map: https://github.com/fpdcc/trailsy/blob/development/js/activityFeature.js#L115

JavaScript

In activities table:

• if atype = accessible fishing --> icon-fishing-accessible svg on map
• if accessible = 1 & atype = "canoe landing" --> use icon-canoe-landing-accessible svg on map
• if accessible = 1 & atype = "boat launch" --> use icon-boat-launch-accessible svg on map

@shua123 We want to use the new accessible column to mark accessible versions of amenities--canoe landings are the first, but won't be the last. It helps us keep our data cleaner (limited atype), but let me know if this won't work with how we are displaying icons currently.

SVG

In updated defs.svg https://github.com/fpdcc/trailsy/commit/056d1f3229fe6b9b8daa47b9636ae44d571cb6c5

CSS

Updated in newguts.css https://github.com/fpdcc/trailsy/commit/48e4ea0a23bc852a1878dd95dac67e3fa4b08e8f

[gisdevcc]

@versatilehuman I am wondering about the use of "ada" as the field name in activities. In issue #251 the picnicgroves equivalent is named "accessible." Is there a reason not to use accessible here too?

[versatilehuman]

@gisdevcc "ada" was an existing column in points_of_interest and activities, so we went with that. I'm for updating it to "accessible" there if that works for @glw.

[gisdevcc]

Going the other direction works too. I just figured if they mean the same thing, we should standardize on one term, unless there is a reason not to.

[glw]

ive changed the poi column "ada" to "accessible" in the latest update.

[gisdevcc]

db changes: https://github.com/fpdcc/trailsyserver/commit/ea7c02f22881c964b52dd1e55d86fc6d2dea9595

[versatilehuman]

@gisdevcc I'm not seeing accessible fishing areas, accessible canoe landings, accessible boat launches or accessible campsites on the map or in the panel. Looks like the necessary data is there in the latest update though.

[gisdevcc]

@versatilehuman Try again. I forgot to update some of the data on staging.

[versatilehuman]

@gisdevcc Now seeing it on the map, but not the panel:

[gisdevcc]

@versatilehuman Should be fixed now via https://github.com/fpdcc/trailsyserver/commit/02faad09239d91d65ef441503f938c797bd4c8de

[versatilehuman]

@gisdevcc Fishing areas, campsites and boat launches look good, still not seeing canoe landing:

And can we tweak the logic for boat launches and canoe landings so:

• If there is boat_ramp AND accessible_boat, only accessible_boat shows in the panel
• If there is canoe AND accessible_canoe, only accessible_canoe shows in the panel

Also, can you drop the "s" from the end so it is Accessible Fishing Area? (my bad)

[gisdevcc]

@versatilehuman canoe landing is fixed, logic tweaked, and fishing area on staging.