Open MHA: Attack and Decay Optimization

fpga-open-speech-tools / simulink_models

Simulink models for speech and audio processing

MIT License

4 stars 4 forks source link

Open MHA: Attack and Decay Optimization #57

Closed dack-fe closed 3 years ago

dack-fe commented 3 years ago

Verify the attack and decay optimization compared to the original source code from Open MHA - dc.cpp - Line 282

attack_decay_filter.slx
I have added some comments explaining the optimization, however I am confused on the final logic step of the block

dack-fe commented 3 years ago

@matthewblunt and @fe-wickham Can you please review the update to the Attack & Decay Filter Block.

matthewblunt commented 3 years ago

After looking it over, I think this implementation makes sense. It's still a bit confusing when I compare it to the documentation but I think it could very well be correct.

dack-fe commented 3 years ago

I just update the comment in the Simulink Model. I will review the documentation that Matt provided as well as implement MATLAB Validation without the optimization on Monday.

The MATLAB Validation will use 2 complete attack and release filters and the corresponding coefficients based on the source code.

dack-fe commented 3 years ago

@matthewblunt and @fe-wickham Can you please review the Attack & Decay Filter Block along with the model parameters and validation scripts?

dack-fe commented 3 years ago

Updated with non-optimized attack and decay filter