search

fpga-open-speech-tools / simulink_models

Simulink models for speech and audio processing
MIT License
4 stars 4 forks source link

Simulink Model Removal #76

Closed dack-fe closed 3 years ago

dack-fe commented 3 years ago

Removed the old and non-Frost folders and projects

dack-fe commented 3 years ago

Do we want to move the following to a new repo called Old Projects or something similar:

  1. HA_sys8?
  2. JMAP Speech Enhancement Project?
  3. Acoustic Delay?

Are any of these projects relevant? Working? Worth Keeping?

rksnider commented 3 years ago

I would put them under Old Projects as you suggest. HA_sys8 is the old hearing aid based on band-pass FIR filters. I can't remember what the other two are.

Ross

On Tue, Jan 26, 2021 at 12:08 PM Connor Dack notifications@github.com wrote:

Do we want to move the following to a new repo called Old Projects or something similar:

  1. HA_sys8?
  2. JMAP Speech Enhancement Project?
  3. Acoustic Delay?

Are any of these projects relevant? Working? Worth Keeping?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fpga-open-speech-tools/simulink_models/pull/76#issuecomment-767762989, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNDUXC2HPMPGSOSYB5UAYDS34HLRANCNFSM4WT6QF3Q .

fe-tdavis commented 3 years ago

I agree, let's put them in a new repo.

tvannoy commented 3 years ago

JMAP Speech Enhancement was an intern project that was never quite finished. Acoustic Delay Buffer was basically just a dual port RAM for an earlier beamforming project; it was created in Intel's DSP Builder. Both of those projects can be deleted.

Somebody (most likely @rksnider) might want to look at HA_sys8 in the future for some reason. However, we don't technically need to keep anything in a separate repo because we can always access them in the git history if needed (in particular, this PR would be an easy place to start to find relevant commits). If we do put anything in an "Old Projects" repo, I think the repo should be private and/or archived.

fe-wickham commented 3 years ago

If the only old model we want to keep is HA_sys8, I'd be preferential to just leaving it where it is and adding a ReadMe to it explaining it to be a preserved relic. That seems better than making a whole repo, private or otherwise, over a single old model. (Git history is technically an option, but given the intended potential users seems less viable)

dack-fe commented 3 years ago

HA_sys8 was left in the current folder. More discussion can be had during the merge into Dev. For now, we can focus on updating the remaining projects.

tvannoy commented 3 years ago

More discussion can be had during the merge into Dev.

Just throwing this out here so I don't forget. Keeping HA_sys8 sounds good, but we should consider giving it a better name when merging into dev.

rksnider commented 3 years ago

I agree

On Tue, Jan 26, 2021 at 3:48 PM Trevor Vannoy notifications@github.com wrote:

JMAP Speech Enhancement was an intern project that was never quite finished. Acoustic Delay Buffer was basically just a dual port RAM for an earlier beamforming project; it was created in Intel's DSP Builder. Both of those projects can be deleted.

Somebody (most likely @rksnider https://github.com/rksnider) might want to look at HA_sys8 in the future for some reason. However, we don't technically need to keep anything in a separate repo because we can always access them in the git history if needed (in particular, this PR would be an easy place to start to find relevant commits). If we do put anything in an "Old Projects" repo, I think the repo should be private and/or archived.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fpga-open-speech-tools/simulink_models/pull/76#issuecomment-767878454, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNDUXFW2L3DNRXGZHP2VDDS35BEZANCNFSM4WT6QF3Q .

rksnider commented 3 years ago

HA_sys8 can be removed. This was really just to get a filtering system working quickly. Modern hearing aids use the frequency domain, i.e. FFT approach.

Ross

On Tue, Jan 26, 2021 at 4:52 PM Connor Dack notifications@github.com wrote:

HA_sys8 was left in the current folder. More discussion can be had during the merge into Dev. For now, we can focus on updating the remaining projects.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fpga-open-speech-tools/simulink_models/pull/76#issuecomment-767906768, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNDUXD5GX47DOCKBV7YSXDS35IURANCNFSM4WT6QF3Q .

rksnider commented 3 years ago

If we keep it, we should call it FIR_system.

Ross

On Tue, Jan 26, 2021 at 5:05 PM Trevor Vannoy notifications@github.com wrote:

More discussion can be had during the merge into Dev.

Just throwing this out here so I don't forget. Keeping HA_sys8 sounds good, but we should consider giving it a better name when merging into dev.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fpga-open-speech-tools/simulink_models/pull/76#issuecomment-767911444, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNDUXGWGRSSK7P67BU4ZRDS35KDFANCNFSM4WT6QF3Q .