fpga-open-speech-tools / simulink_models

Simulink models for speech and audio processing
MIT License
4 stars 4 forks source link

Echo Verification Script and Minor Updates #77

Closed fe-tdavis closed 3 years ago

fe-tdavis commented 3 years ago

Created a verification function for this implementation of the echo, added a README, and renamed the model.

fe-tdavis commented 3 years ago

There is a slight difference between the verification function and the Simulink model. Maybe it's due to a gain somewhere along the way?

fe-wickham commented 3 years ago

On the naming convention for the model, while with the ANM we did do '_sim' all the way to the final generated model, given that the name in the model.json must match the model name and having '_sim' looks worse we have stuck with just the effect/algorithm name rather than name_sim for models that will be generated. If 'echo_sim' isn't renamed back to 'echo', then the model.json does need to be updated to reflect the new name