search

fpga-open-speech-tools / simulink_models

Simulink models for speech and audio processing
MIT License
4 stars 4 forks source link

Cleanup top level #93

Open fe-wickham opened 3 years ago

fe-wickham commented 3 years ago

Updated the rest of the models to match DSBF use of the cleaner registers and testSignal (no conversion needed)

tvannoy commented 3 years ago

Does this supersede #89? If so, we can cherry-pick in my couple commits from that PR into this branch.

fe-wickham commented 3 years ago

Does this supersede #89? If so, we can cherry-pick in my couple commits from that PR into this branch.

It was sort of the follow-up to #89 because I wanted a PR for an individual model with these updates to be reviewed well. You could cherry pick your commits or we can just merge #89 then this PR

tvannoy commented 3 years ago

It was sort of the follow-up to #89 because I wanted a PR for an individual model with these updates to be reviewed well. You could cherry pick your commits or we can just merge #89 then this PR

Okay. I don't necessarily prefer one approach over the other. Merging #89 first would work since it is already approved. However, if we do that, we should rebase this branch to remove commit 4d05a05 since it is in both branches.

tvannoy commented 3 years ago

Rebased changes after merging #89