fpgaminer / rust-lzma

A Rust crate that provides a simple interface for LZMA compression and decompression.
MIT License
79 stars 14 forks source link

Static linking support #28

Closed ajeetdsouza closed 1 year ago

ajeetdsouza commented 1 year ago

Hey, thanks for a fantastic crate! It would be great if you could support static linking - that way, we wouldn't have to rely on the host computer having liblzma installed.

fpgaminer commented 1 year ago

Thank you, but I'm sorry to say I'm not maintaining this repo at the moment. There are better lzma Rust crates.

crazystylus commented 1 year ago

Hi @fpgaminer , It's not valid to say other crates are better. I have some issues with basic xz extraction on other crates while I am getting no issues when using your crate. Please refer to these issues:

I have added support for static linking to your crate in this fork. Would you accept a PR?

fpgaminer commented 1 year ago

It's not valid to say other crates are better.

I mean, they're better because they're maintained... ostensibly, anyway. Odd that your issue on xz2-rs hasn't been touched.

Sure, a PR would be welcome. Please fix the typo(s) if you have a moment.

ajeetdsouza commented 1 year ago

Odd that your issue on xz2-rs hasn't been touched.

Unfortunately, there are a lot of similar issues on xz2: https://github.com/alexcrichton/xz2-rs/issues/75#issuecomment-780776200

fpgaminer commented 1 year ago

Merged, and I've pushed a new version to crates.io.

crazystylus commented 1 year ago

Merged, and I've pushed a new version to crates.io.

Thanks!!