Closed pboulos closed 2 weeks ago
@fpgmaas I wanted to ask if you could take a look at this. They've been errors that I've been encountering while using this template that I've needed to manually fix before using it every time; I thought it would be useful to make the PR for others to benefit from.
@fpgmaas I wanted to ask if you could take a look at this. They've been errors that I've been encountering while using this template that I've needed to manually fix before using it every time; I thought it would be useful to make the PR for others to benefit from.
hanks for the contribution, and sorry for the late response! I was on holiday the past three weeks. I left one small comment; I'm happy to merge the PR after that is processed.
PR Checklist
Description of changes
When running CI, we observe the following errors due to linting.
This PR applies some formatting changes across the repo such that these tests are now passed in the initial commit. This appears to be related to https://github.com/fpgmaas/cookiecutter-poetry/issues/96 and https://github.com/fpgmaas/cookiecutter-poetry/pull/97.
Changes include:
{{cookiecutter.project_name}}/.devcontainer/devcontainer.json
to be on a single line.{{cookiecutter.project_name}}/.github/actions/setup-poetry-env/action.yml
.{{cookiecutter.project_name}}/.github/workflows/main.yml
.{{cookiecutter.project_name}}/.github/workflows/on-release-main.yml
.{{cookiecutter.project_name}}/README.md
.{{cookiecutter.project_name}}/mkdocs.yml
.These changes should not change any user behaviour apart from allowing the CI to pass first time without any user modification.