search

fph / bastet

Evil falling block game. http://fph.altervista.org/prog/bastet.html
GNU General Public License v3.0
272 stars 35 forks source link

Ui.cpp: always use "%s"-style format for printf()-style functions #21

Open trofi opened 2 years ago

trofi commented 2 years ago

ncuses-6.3 added printf-style function attributes and now makes it easier to catch cases when user input is used in palce of format string when built with CFLAGS=-Werror=format-security:

Ui.cpp:293:16: error: format not a string literal and no format arguments [-Werror=format-security]
  293 |       mvwprintw(w,0,0,msg.c_str());
      |       ~~~~~~~~~^~~~~~~~~~~~~~~~~~~

Let's wrap all the missing places with "%s" format.