fpillet
commented
5 years ago Yeah! Thanks for all the hard work!
Closed stuffmc closed 5 years ago
fpillet
commented
5 years ago Yeah! Thanks for all the hard work!
In the process of making the Viewer look decent on macOS 10.14's Dark Mode (which I love like many, especially for the evenings/nights), I did this as well:
• Upgraded to recommended settings in Xcode 10.1 — and obviously Base SDK 10.14 • Dropped support for Snow Leopard. Only 🦖 still use Snow Leopard anyways, especially for the viewer! So we now have Deployment Target 10.7 — like it's the 20th century ;) • Removed all the BWToolkit references/usages — also removed it from the Readme. • Used the accent color for the Header. Obviously a lot of other "Dark mode" changes.
In essence the job was to remove a lot of "hard coded" colors as well as creating the ability to have 2 set of preferences, much like Xcode.
What I didn't do:
• Swapping the green used for the row selection. Partly on purpose (it's NSLoggers' CI, somehow), partly because I couldn't find where it's defined. I also think it looks good on both (Light and Dark) anyways, so it might be okay.
• Testing on anything else than Mojave, because I don't have anything else anymore, but you (Florent) will check on 10.13 anyways ;) and maybe we can find some crazy people still using < 10.13 to test it. Really since it's the Viewer we could probably only support 10.13, but then we'll have a ton of warnings additionally.
• Fixing all the "Implicit conversion" warning — Check them please, make this baby Warning free ;)