search

fpillet / NSLogger

A modern, flexible logging tool
Other
5k stars 573 forks source link

Backwards compatibility issue #278

Open vladiulianbogdan opened 5 years ago

vladiulianbogdan commented 5 years ago

Hi,

I've noticed that the NSLoggerData files generated before 10th December are not compatible anymore with newer versions of NSLogger. The logs will not appear in NSLogger if I try to open an .nslogger file.

In the commit with hash eef947f it seems like the LoggerConnection.m file was modified. In the initWithCoder method, the keys are different. That means file that were generated, for example, with key "message" and not compatible now with newer version because they are using key "_message".

Was this intended? If not, I have a fix this in a fork. Let me know if you want me to push a PR.

NSLogger is great! Thanks!

fpillet commented 5 years ago

I think this is a side effect of converting the viewer code from MRC to ARC! I didn't notice that we had backward compatibility issues, so yes please push your PR - thanks a lot!

vladiulianbogdan commented 5 years ago

Here it is: https://github.com/fpillet/NSLogger/pull/279.

c0diq commented 5 years ago

Can we close this one?