fplll / fpylll

A Python interface for https://github.com/fplll/fplll
GNU General Public License v2.0
122 stars 62 forks source link

Fix some broken declarations and imports when not HAVE_LONG_DOUBLE #105

Closed embray closed 6 years ago

embray commented 6 years ago

I feel like there's got to be a way to more cleanly manage imports for optionally defined types as in the HAVE_LONG_DOUBLE and HAVE_QD cases. I'll have to think about that more in the meantime.

embray commented 6 years ago

Or if nothing else maybe I could add some configurations on the travis build to test these special cases, or at least that it builds.

malb commented 6 years ago

Adding Travis-CI tests for this would be ace!

embray commented 6 years ago

Yeah I was thinking that would at least be a start. I'll gladly take care of it, as long as you don't mind adding a couple additional test configurations.

malb commented 6 years ago

Adding a couple of test configurations sounds fine to me, I'd rather have tests that make it works than quick ones that don't tell the full story.

embray commented 6 years ago

Should be fixed now.