fplll / fpylll

A Python interface for https://github.com/fplll/fplll
GNU General Public License v2.0
123 stars 62 forks source link

Include tests/tools.py in release tarball #199

Closed jamesjer closed 3 years ago

jamesjer commented 3 years ago

I'm looking at updating the Fedora fpylll package, but am getting test failures:

==================================== ERRORS ====================================
______________________ ERROR collecting tests/test_bkz.py ______________________
ImportError while importing test module '/builddir/build/BUILD/fpylll-0.5.3.dev0/tests/test_bkz.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test_bkz.py:7: in <module>
    import tools
E   ModuleNotFoundError: No module named 'tools'
_____________________ ERROR collecting tests/test_enum.py ______________________
ImportError while importing test module '/builddir/build/BUILD/fpylll-0.5.3.dev0/tests/test_enum.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test_enum.py:6: in <module>
    import tools
E   ModuleNotFoundError: No module named 'tools'
______________________ ERROR collecting tests/test_gso.py ______________________
ImportError while importing test module '/builddir/build/BUILD/fpylll-0.5.3.dev0/tests/test_gso.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test_gso.py:10: in <module>
    import tools
E   ModuleNotFoundError: No module named 'tools'
______________________ ERROR collecting tests/test_lll.py ______________________
ImportError while importing test module '/builddir/build/BUILD/fpylll-0.5.3.dev0/tests/test_lll.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test_lll.py:8: in <module>
    import tools
E   ModuleNotFoundError: No module named 'tools'
=========================== short test summary info ============================
ERROR test_bkz.py
ERROR test_enum.py
ERROR test_gso.py
ERROR test_lll.py
!!!!!!!!!!!!!!!!!!! Interrupted: 4 errors during collection !!!!!!!!!!!!!!!!!!!!
============================== 4 errors in 0.18s ===============================

It looks like there is a file tests/tools.py in git, but it was not included in the 0.5.3.dev0 tarball.

malb commented 3 years ago

Thanks. Fixed on master, CI checks being added to prevent this from happening again. Will cut a new release fixing this.