Converted codes.py to Python3 and fixed launch_all

fplll / g6k

The General Sieve Kernel

GNU General Public License v2.0

103 stars 31 forks source link

Converted codes.py to Python3 and fixed launch_all #60

Closed joerowell closed 3 years ago

joerowell commented 3 years ago

I think I may be the only person who has ever used this script, but that doesn't mean it shouldn't be Python 3.

This PR:

This PR converts codes.py to Python 3. I also blackened the source file to make sure it's all nicely formatted etc.
I also fixed the launch_all file: briefly, the first few commands would lead to the commands not terminating (we check the permutation in random_sparse_codes but for small values of n this leads to an infinite loop). It now starts at 6, which seems to be where this issue stops.

malb commented 3 years ago

Ace. Could we add a test to make sure codes.py doesn't break in the future?

joerowell commented 3 years ago

Ace. Could we add a test to make sure codes.py doesn't break in the future?

It's probably unfair to say that codes.py broke - it just wasn't updated to Python 3. We could write some KATs, but it seems pretty non-deterministic to me: a better solution might be "If the code generated is above this quality threshold". Is this what you had it mind?

malb commented 3 years ago

Even it not crashing would be a start

malb commented 3 years ago

Is this one ready or shall I wait for some rudimentary tests?

joerowell commented 3 years ago

You may as well merge it: I've added an "exit if less than 6" check, but I don't know if I'll have time any time soon to add anything more robust.