search

fpompermaier / onvif

Java ONVIF library
Apache License 2.0
191 stars 88 forks source link

Java 11 support? #12

Closed Bhlowe closed 5 years ago

Bhlowe commented 5 years ago

Did anyone get this to compile and run on newer versions of java? This is more of a generic "how to get javax.xml.soap, jaxb2 to run on java 11.. but hoping someone has a quick pointer..

I can add dependencies to get it to compile, but then run errors like: Error: Unable to initialize main class org.onvif.client.SimpleTest Caused by: java.lang.ClassFormatError: Absent Code attribute in method that is not native or abstract in class file javax/xml/soap/SOAPException

I'll try to answer my own question.. but thought I'd ask... Thanks!

fpompermaier commented 5 years ago

Have you tried to look at this? https://www.dariawan.com/tutorials/java/using-jaxb-java-11/

Bhlowe commented 5 years ago

That helped! I think I have it.. I'm happy to submit a PR if you want, but it may not be suitable for all users.

https://github.com/Bhlowe/onvif

My changes adds the javax code to all builds, which is probably not ideal. I think a better solution is to use java profiles to add code... or just add the java 9+ dependencies to the code base that wants to use your code with a java 9+ project. I will probably experiment with that and comment here.

I am going to test it a bit more on my webcam rebroadcasting app, siteproxy.. Will try to add value back if I can.. but unfortunately, soap is not my specialty.

Again.... thanks for your hard work!

Bhlowe commented 5 years ago

Removed this comment.. no solved... working on fixing discovery.

Bhlowe commented 5 years ago

Ok. Fixed. Set WSDL_LOCATION to null and that matches he behavior in the previous release. I think I have a version that will build 8-12. Disregard last message. Just want to make sure my fork can be built using jdk 8.

fpompermaier commented 5 years ago

Great!

On Fri, 19 Jul 2019 at 05:54, Bhlowe notifications@github.com wrote:

Ok. Fixed. Set WSDL_LOCATION to null and that matches he behavior in the previous release. I think I have a version that will build 8-12. Disregard last message. Just want to make sure my fork can be built using jdk 8.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fpompermaier/onvif/issues/12?email_source=notifications&email_token=AA4Z4JNRVAQ7GGINOWPCK7LQAE3JDA5CNFSM4H66XGB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KP3FA#issuecomment-513080724, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4Z4JJFALMC3SSN3JCS7GLQAE3JDANCNFSM4H66XGBQ .

fpompermaier commented 5 years ago

Fixed by 42ac69c9d0cf1fdc6e35c77281f859f866572129