search

fppimenta / rheoTool

Toolbox to simulate GNF and viscoelastic fluid flows in OpenFOAM®
GNU General Public License v3.0
162 stars 67 forks source link

Clang Compatibility #42

Closed BrushXue closed 3 years ago

BrushXue commented 3 years ago

I only modified the code in OF 7.0 folder and have tested several tutorial cases without problems. Now it's Clang compatible (macOS compatible as well). I believe the code still works under gcc but please test it. I know there's still some incompatible code left in the tutorial case. I can help update these when I have time.

fppimenta commented 3 years ago

I have no time to thoroughly check the code and provide support for that compiler. Makes more sense to keep that version in your forked repo. Won't merge.

BrushXue commented 3 years ago

I understand that you're busy and don't have time to check everything. Just a friendly reminder that when initializing an field in OpenFOAM, for example volVectorField A=B is not a standard C++ syntax. GCC can compile doesn't mean it's correct. I helped you fixed all of them so now your code complies with C++ standard.

guycoates commented 3 years ago

Can you re-consider merging these changes? llvm compatibility means the code is buildable with the AMD optimizing compiler suite.

BrushXue commented 3 years ago

Can you re-consider merging these changes? llvm compatibility means the code is buildable with the AMD optimizing compiler suite.

You can try my fork https://github.com/BrushXue/rheoTool/tree/Mac. However I didn't test it with Linux.(I had really bad experience with AOCC on HPC).