search

fpravica / grep4j

Automatically exported from code.google.com/p/grep4j
0 stars 0 forks source link

GrepResult#linePattern #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It should not use System.getProperty("line.separator"), because it is 
impossible to grep unix files from windows, when you cannot override it.

Original issue reported on code.google.com by vojta.kr...@gmail.com on 10 Jul 2013 at 2:34

GoogleCodeExporter commented 9 years ago 
This is really important for us to have this fix.
I would suggest to change it to:

private static final Pattern linePattern = Pattern.compile(".*\\r?\\n");

This would solve Windows/Linux line ending differences

Original comment by tomek.ka...@gmail.com on 14 Nov 2013 at 8:25

GoogleCodeExporter commented 9 years ago 
I ll made the changes today and you should have a new release by the end of the 
weekend

Original comment by marcocast@gmail.com on 14 Nov 2013 at 9:29

GoogleCodeExporter commented 9 years ago

Original comment by marcocast@gmail.com on 14 Nov 2013 at 10:04

GoogleCodeExporter commented 9 years ago 
Version 1.8.6 has been released with the suggested line pattern (".*\\r?\\n").
Let me know if this is enough to solve your problem.

Original comment by marcocast@gmail.com on 17 Nov 2013 at 8:51

GoogleCodeExporter commented 9 years ago 
It works fine now, thank You!

Original comment by tomek.ka...@gmail.com on 19 Nov 2013 at 8:12