build error encountered with `build-fprime-automatic-teensy41/Components/Sensors/IMU_MPU9250/IMU_MPU9250ComponentAc.cpp`

[capsulecorplab]

[ethancheez]

Were there changes in fprime or fpp-tools @LeStarch? The fprime commit currently checkout out in this submodule results in a successful build.

After I bumped up the version by running git submodule update --remote --recursive and rebuilding, I got the same error above. I reverted back fprime and I could successfully build again.

[ethancheez]

After comparing the IMU_MPU9250ComponentAc.cpp files generated from both fprime versions, I found this discrepancy:

The new cpp file is missing this:

  // ----------------------------------------------------------------------
  // Mutex functions for guarded ports
  // ----------------------------------------------------------------------

  void IMU_MPU9250ComponentBase ::
    lock()
  {
    this->m_guardedPortMutex.lock();
  }

  void IMU_MPU9250ComponentBase ::
    unLock()
  {
    this->m_guardedPortMutex.unLock();
  }

and if you're curious about any other differences... https://www.diffchecker.com/fn5RbfHM/

[LeStarch]

It looks like these files changed with the change to fpp-to-cpp.

[LeStarch]

@bocchino do you know any reason these two functions would not have been generated?

[LeStarch]

@capsulecorplab @ethancheez did you purge and regenerate after bumping versions? If not, this is likely the cause.

[ethancheez]

@capsulecorplab @ethancheez did you purge and regenerate after bumping versions? If not, this is likely the cause.

Yes, I purged and regenerated

[LeStarch]

@ethancheez I confirmed it is a bug in FPP. I am filing an issue now: https://github.com/fprime-community/fpp/issues/315

[capsulecorplab]

@capsulecorplab @ethancheez did you purge and regenerate after bumping versions? If not, this is likely the cause.

Affirmative; Build cache was purged and regenerated

[LeStarch]

Note: a PR has been submitted to fix this issue: https://github.com/fprime-community/fpp/pull/316

[LeStarch]

The fix is merged into FPP! We'll get a new release out the door soon.

[ethancheez]

Closing since this issue is fixed.