search

fpthink / 3D-WSIS

Learning Inter-Superpoint Affinity for Weakly Supervised 3D Instance Segmentation
22 stars 1 forks source link

Attribution of SPG and Cut Pursuit #4

Open loicland opened 1 year ago

loicland commented 1 year ago

Hi, good job for the fun project!

I am noting however that you verbatim copy-pasted two of our repositories directly into yours:

https://github.com/loicland/superpoint_graph/tree/ssp%2Bspg/partition is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/data/S3DIS/partition

https://github.com/loicland/superpoint_graph/tree/ssp%2Bspg/learning/ecc is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/modules/model/ecc

https://github.com/loicland/cut-pursuit is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/data/S3DIS/partition/cut-pursuit

Please use submodules for this, and make this dependency explicit in your README, the repos are not in the aknowledgements.

You also did not cite "Cut Pursuit: fast algorithms to learn piecewise constant functions on general weighted graphs" in your paper, even though you use the code verbatim in your repository. Please fix this as well.

Otherwise, I'm thrilled to see our work used to explore new ideas and give such amazing results!

fpthink commented 1 year ago

Hi, good job for the fun project!

I am noting however that you verbatim copy-pasted two of our repositories directly into yours:

https://github.com/loicland/superpoint_graph/tree/ssp%2Bspg/partition is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/data/S3DIS/partition

https://github.com/loicland/superpoint_graph/tree/ssp%2Bspg/learning/ecc is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/modules/model/ecc

https://github.com/loicland/cut-pursuit is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/data/S3DIS/partition/cut-pursuit

Please use submodules for this, and make this dependency explicit in your README, the repos are not in the aknowledgements.

You also did not cite "Cut Pursuit: fast algorithms to learn piecewise constant functions on general weighted graphs" in your paper, even though you use the code verbatim in your repository. Please fix this as well.

Otherwise, I'm thrilled to see our work used to explore new ideas and give such amazing results!

Thank you for your excellent works: SPG and Cut Pursuit. We will update the README soon.

fpthink commented 1 year ago

Hi, good job for the fun project!

I am noting however that you verbatim copy-pasted two of our repositories directly into yours:

https://github.com/loicland/superpoint_graph/tree/ssp%2Bspg/partition is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/data/S3DIS/partition

https://github.com/loicland/superpoint_graph/tree/ssp%2Bspg/learning/ecc is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/modules/model/ecc

https://github.com/loicland/cut-pursuit is copy-pasted here: https://github.com/fpthink/3D-WSIS/tree/45b3ccc7e2831df5f2755fe239af3890ea2bee68/data/S3DIS/partition/cut-pursuit

Please use submodules for this, and make this dependency explicit in your README, the repos are not in the aknowledgements.

You also did not cite "Cut Pursuit: fast algorithms to learn piecewise constant functions on general weighted graphs" in your paper, even though you use the code verbatim in your repository. Please fix this as well.

Otherwise, I'm thrilled to see our work used to explore new ideas and give such amazing results!

Thank you for your excellent works: SPG and Cut Pursuit. We will update the README soon.