fpv-wtf / msp-osd

MSP DisplayPort OSD
GNU General Public License v3.0
226 stars 32 forks source link

disable_betaflight_hd is undefined in schemaV2.json #113

Closed j005u closed 1 year ago

j005u commented 1 year ago

image

Looks like disable_betaflight_hd was only added to schema.json.

Technically schema.json can be dropped, as long as package-config isn't actually used.

bri3d commented 1 year ago

https://github.com/fpv-wtf/msp-osd/blob/main/config/airunit/schemaV2.json#L44 erm?

j005u commented 1 year ago

https://github.com/fpv-wtf/msp-osd/blob/main/config/airunit/schemaV2.json#L44 erm?

Erm indeed. I saw two people post screenshots with the same issue (no name or description) and presumed it's undefined.

Will dig out a vista and try to repro.

bri3d commented 1 year ago

I can take a look too, my first thought was some kind of issue parsing the descriptor, but it looks right on a cursory glance. Weird.

j005u commented 1 year ago

Derp herp, hurr durr. Totally missed it the first 3 times.

"name" - "title".

Also for osd_update_rate_hz.

This can be helpful for sanity checks: https://rjsf-team.github.io/react-jsonschema-form/

benlumley commented 1 year ago

Has been fixed (by bri, not me!)