search

fpv-wtf / wtfos-configurator

Configurator for wtfos, with built in margerine
GNU Affero General Public License v3.0
42 stars 16 forks source link

Weird Rendering glitch when applying OSD Overlay. #289

Open keggyhander opened 1 year ago

keggyhander commented 1 year ago

I thought there was something wrong with my Caddx Vista when I was getting weird glitches in my videos. It was only when I compared the raw video with the ones that had had the OSD rendered in that I noticed the source of the glitch was your software process. Here's a video showing the glitch: https://youtu.be/Oum5dfal44M

Here's a video in split screen showing raw video against the OSD-overlaid version: https://www.youtube.com/watch?v=z6U-QKHOX0k

I would like to solve this because I like the look of my particular OSD

Cheers

FinalFrag commented 1 year ago

Can you upload the original file, the .osd file and the fonts used?

keggyhander commented 1 year ago

https://mega.nz/folder/QPJ0TB6B key:DGpuaAjlUxuXYCDFkCdTwA

keggyhander commented 1 year ago

https://mega.nz/folder/QPJ0TB6B key:DGpuaAjlUxuXYCDFkCdTwA

From: Massimo Mertens @.> Sent: 27 February 2023 18:57 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

Can you upload the original file, the .osd file and the fonts used?

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1446884635, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543VNA4I3E4BIUOHBCBDWZT2LPANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

FinalFrag commented 1 year ago

The output video looks good when I run it through the osd-overlay that is currently on the develop branch. Could you try it again? If the issue is still there, what machine are you running it on? PC/Mac/MacM1?

keggyhander commented 1 year ago

PC win 10 64

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Massimo Mertens @.> Sent: Monday, February 27, 2023 11:06:24 PM To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

The output video looks good when I run it through the osd-overlay that is currently on the develop branch. Could you try it again? If the issue is still there, what machine are you running it on? PC/Mac/MacM1?

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1447251161, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543SH4NFVAMB3UN4SZUTWZUXPBANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

keggyhander commented 1 year ago

Tried it again from here: https://knifa-develop.fpv.wtf/osd-overlay If anything it was even worse than before. What is this develop branch you speak of?

FinalFrag commented 1 year ago

I forgot the current development branch has not been released publicly yet. Nevermind that.

I ran your files through that version as well, and they come out ok. Must be something specific about your setup. Could you try another browser and see if that has any effect? What browser did you use now?

keggyhander commented 1 year ago

Chrome

From: Massimo Mertens @.> Sent: 01 March 2023 20:52 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

I forgot the current development branch has not been released publicly yet. Nevermind that.

I ran your files through that version as well, and they come out ok. Must be something specific about your setup. Could you try another browser and see if that has any effect? What browser did you use now?

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1450827891, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543WF5YFH3G74F7C3R3TWZ6ZIJANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

stylesuxx commented 1 year ago

The develop branch is actually being automatically deployed to https://develop.fpv.wtf/

keggyhander commented 1 year ago

Losing patience with this now. If it doesn't work in chrome, what use is it, really?

stylesuxx commented 1 year ago

Alright, if you don't want help and don't have time to invest, feel free not to use it.

keggyhander commented 1 year ago

I spent plenty of time and energy rooting my devices in order to use it and spent ages setting up my optimum OSD set up. I don't quite know what more you expect me to do on my end to remove this annoying glitch in the overlay render.

From: Chris @.> Sent: 01 March 2023 21:59 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

Alright, if you don't want help and don't have time to invest, feel free not to use it.

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1450905718, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543XB4YDTLQFBTAY2YITWZ7BCLANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

keggyhander commented 1 year ago

I don't have any other browsers installed. Which one would YOU suggest?

From: Chris @.> Sent: 01 March 2023 21:59 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

Alright, if you don't want help and don't have time to invest, feel free not to use it.

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1450905718, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543XB4YDTLQFBTAY2YITWZ7BCLANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

stylesuxx commented 1 year ago

Well, you are being pretty entitled. You think we just snap our fingers and things get resolved magically? We ask questions and hope to drill down where the issue is coming from. If we could reproduce the issues on our end, we would not need to ask those questions.

We put a lot of our SPARE time and energy into this and the only thing we ask in return is to treat us with a minimum amount of respect. No need to get inpatient here.

Since you are on Windows you could for example try it on Edge. If at all possible you could also try it on a different machine. Please also post exact version of Chrome you are using.

keggyhander commented 1 year ago

Version 110.0.5481.178 (Official Build) (64-bit)

I'm not being entitled at all. You're the clever ones. I would expect you to have more answers than me. It creates the file, just with weird glitches. I bet there are more complaints from people for whom the file doesn't even start rendering. My impatience is whether to bother with it at all. Not with you. Have you ever seen this glitch before? If you haven't, then just say so.

From: Chris @.> Sent: 01 March 2023 22:09 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

Well, you are being pretty entitled. You think we just snap our fingers and things get resolved magically? We ask questions and hope to drill down where the issue is coming from. If we could reproduce the issues on our end, we would not need to ask those questions.

We put a lot of our SPARE time and energy into this and the only thing we ask in return is to treat us with a minimum amount of respect. No need to get inpatient here.

Since you are on Windows you could for example try it on Edge. If at all possible you could also try it on a different machine. Please also post exact version of Chrome you are using.

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1450918119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543VP7QHUBHO5BCIJIITWZ7CJTANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

keggyhander commented 1 year ago

Right, I've downloaded Edge, and tried it on there. It still presents a very minor glitch in one place, but is very much improved. With that in mind, what do suggest is at the heart of the problem?

From: Chris @.> Sent: 01 March 2023 22:09 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

Well, you are being pretty entitled. You think we just snap our fingers and things get resolved magically? We ask questions and hope to drill down where the issue is coming from. If we could reproduce the issues on our end, we would not need to ask those questions.

We put a lot of our SPARE time and energy into this and the only thing we ask in return is to treat us with a minimum amount of respect. No need to get inpatient here.

Since you are on Windows you could for example try it on Edge. If at all possible you could also try it on a different machine. Please also post exact version of Chrome you are using.

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1450918119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543VP7QHUBHO5BCIJIITWZ7CJTANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

FinalFrag commented 1 year ago

I'm running the same version of chrome as you do. I also tried it in edge. Both result in no glitches.

At this point, I have no idea what is at the heart of this problem.

I have seen glitching before in my own files that were edited, but never in files straight from the goggles. I analysed your file and it has all the correct info in it that it should process fine.

I need to be able to reproduce the issue on my own machine before I can start digging. I'm gonna try to set up a clean install of windows in a virtual machine tomorrow, see if that makes a difference.

When you re-run the files in the same browser, do the glitches always appear in the same spots or is it random?

Are you doing anything else with the pc while the process is running or are you just waiting with the browser window in the foreground?

keggyhander commented 1 year ago

Virtually/exactly the same.

From: Massimo Mertens @.> Sent: 01 March 2023 23:50 To: fpv-wtf/wtfos-configurator @.> Cc: keggyhander @.>; Author @.> Subject: Re: [fpv-wtf/wtfos-configurator] Weird Rendering glitch when applying OSD Overlay. (Issue #289)

I'm running the same version of chrome as you do. I also tried it in edge. Both result in no glitches.

At this point, I have no idea what is at the heart of this problem.

I have seen glitching before in my own files that were edited, but never in files straight from the goggles. I analysed your file and it has all the correct info in it that it should process fine.

I need to be able to reproduce the issue on my own machine before I can start digging. I'm gonna try to set up a clean install of windows in a virtual machine tomorrow, see if that makes a difference.

When you re-run the files in the same browser, do the glitches always appear in the same spots or is it random?

— Reply to this email directly, view it on GitHubhttps://github.com/fpv-wtf/wtfos-configurator/issues/289#issuecomment-1451042286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6D543XPAOAFZMS7MJTSMWTWZ7OFFANCNFSM6AAAAAAVIYZFA4. You are receiving this because you authored the thread.Message ID: @.***>

j005u commented 1 year ago

This sounds very likely related to some combination of Chrome and your graphics cards drivers or something along those lines messing up. The support is relatively new and not that robust yet on all devices.

Updating GPU drivers could maybe possibly help. @Knifa is there an easy way to force CPU encoding, to give that try instead? Presuming Chrome defaults to GPU.

PS: Next time, if you want help, please refrain from using statements like "loosing patience" indeed. It works for 99%+ of users. Chrome WebCodecs do indeed have weird edge case bugs depending on the rest of your software/hardware, which are entirely Google's bugs. We do our best to work through them as they come up and solve them if we can. When we have the spare time to do so, completely for free.

So please consider what amount of patience and effort it takes from the devs before taking out your frustration here.

Hope we're able to get you sorted in the end.

preisedj commented 11 months ago

Same here. https://youtu.be/pXApHgllCmA

FinalFrag commented 11 months ago

Same here. https://youtu.be/pXApHgllCmA

Could you upload the source files somewhere?

preisedj commented 11 months ago

Here are the files I'm working with. My flight controller is using Ardupilot, but I have the same results using INav.

https://drive.google.com/drive/folders/1hoAYZ6wh9drOr3gKww1oy9TIsraoYH_x?usp=sharing

j005u commented 11 months ago

@preisedj the fonts you provided on google drive are Betaflight fonts. Please see the issue you opened for the correct font name pattern you should be looking for.

preisedj commented 11 months ago

@preisedj the fonts you provided on google drive are Betaflight fonts. Please see the issue you opened for the correct font name pattern you should be looking for.

Thank you!!! I finally found the right font to use. It was a bit confusing trying to distinguish between the various fonts on GitHub and other sites and whether they work for INAV or Ardupilot but I finally found the winning combination.
Thank you for your quick response and solution.