fpv-wtf / wtfos-configurator

Configurator for wtfos, with built in margerine
GNU Affero General Public License v3.0
42 stars 16 forks source link

OSD Overlay: Incorrect number of frames in joined file prevent process from finishing. #290

Closed vvs1024 closed 1 year ago

vvs1024 commented 1 year ago

Goggles split recordings into multiple files at 10min or ~2.3 GB mark. After I join files back using avidemux or VLC resulting video play fine in any player. If I am trying to apply OSD Overlay on it fails, the process reach the end of combined timeline but never finishes. I can see in the UI that overlay was correctly placed until the end of combined file, so there is nothing wrong with the sync. Problem is that it never finishes and resulted file on the disk is zero size.

In the UI I can see that number of expected frames is very huge and does not represent actual frames number in the file. Attached is example of last frame where process stopped.

Hopefully this is easy fix, just detect that there are no more frames in the source and stop or fix frames number estimation.

image

Knifa commented 1 year ago

The overlay tool doesn't currently support any files other than those that come directly out of the DVR, as it says at the top of the page. 😄

image

This is less obvious though: the OSD recorder side also can't handle split recordings yet --- the .osd file will only have data for the first video file.

If you disable loop recording in the menu, the goggles will generate single continuous video files and then everything will work as expected. Downside being you have to manually clean up your recordings.