search

fpv-wtf / wtfos-configurator

Configurator for wtfos, with built in margerine
GNU Affero General Public License v3.0
42 stars 16 forks source link

While changing settings configurator should not restart a dinit unit that is not currently running #317

Closed j005u closed 1 year ago

j005u commented 1 year ago

Device

Goggles V1

Trace ID (bototm left)

No response

Describe the issue

The new dji-moonlight-shim package is a dinit unit that is normally not running by default.

When I try to save it's settings in this state, I get the error "Failed restarting dji-moonlight-shim" presumably because dinit refused to restart a non-running service. We should check for unit state before attempting to restart on settings apply.

j005u commented 1 year ago

Package was faulty, sorry. Closing.

j005u commented 1 year ago

Turns out package issues were not causing the error message.