search

fpv-wtf / wtfos-configurator

Configurator for wtfos, with built in margerine
GNU Affero General Public License v3.0
42 stars 16 forks source link

V2 Goggles root fail retry that should suggest power cycling and trying again instead suggests butter #320

Closed j005u closed 1 year ago

j005u commented 1 year ago

Device

Goggles V2

Trace ID (bototm left)

No response

Describe the issue

Somewhere along the way the error case handling got messed up. I've seen several reports of people reporting "Failed! Your firmware might not be rootable, please try downgrading with Butter." after having already downgraded with butter.

A restart fixes the problem, which makes me 99% sure it's the old case where the v2 goggles need a power cycle and retry, but people are getting the wrong error message.

I also noticed that when I tried re-rooting my V2 goggles with new firmware installed, I got the old downgrade message, rather than a suggestion to use butter.

It's possible the two error codes got mixed up somewhere?

stylesuxx commented 1 year ago

I also noticed that when I tried re-rooting my V2 goggles with new firmware installed, I got the old downgrade message, rather than a suggestion to use butter.

Fixed.

Somewhere along the way the error case handling got messed up. I've seen several reports of people reporting "Failed! Your firmware might not be rootable, please try downgrading with Butter." after having already downgraded with butter.

You are right - I was showing the "try Butter" message in the event of a "PatchFailed" error, I now added another error message "patchFailed" which has basically the same Text as "unlockFailed" asking the user to power cycle.

Since it's not necessary to have the exploit obfuscated anymore, I think this would also be a good time to add the clear version and remove the obfuscation - what do you think?

j005u commented 1 year ago

Fine by me @ unobfuscating the margerine parts.