search

fpv-wtf / wtfos-configurator

Configurator for wtfos, with built in margerine
GNU Affero General Public License v3.0
42 stars 16 forks source link

OSD Overlay create a MP4 clip much longer than the original #397

Closed FinalFrag closed 11 months ago

FinalFrag commented 11 months ago

This PR fixes #392 OSD Overlay create a MP4 clip much longer than the original

stylesuxx commented 11 months ago

exiftool will still show "truncated data" with this patch?

FinalFrag commented 11 months ago

Yes, I have no idea what is causing that. All I changed was the duration of the clip.

stylesuxx commented 11 months ago

I see. But if this has no other side effects, it is much more preferable than the status quo. in this case I will just add an issue to track this.

FinalFrag commented 11 months ago

Not as far as I can tell.

If I have the time, I want to look into just using ffmpeg to overlay the osd images instead of the whole frame by frame thing and reconstructing the output video we do now. There are so many magic numbers and string involved in the current approach.

Ffmpeg is a cleaner approach, if successful...

stylesuxx commented 11 months ago

So you would instead render on the goggles themselves? The current approach is to keep it device agnostic.

But it would definitely be cool to get this going on the device. I was initially thinking about a gstreamer plugin that just merges osd file and video source. Looking forward to your ffpmeg solution though.

Merged - thanks again for your contribution, very much appreciated! Let me know when you are done with your current "roll", then I'll prepare a new release with all the bugfixes.

j005u commented 11 months ago

@FinalFrag there's some python code https://github.com/Knifa/osd-dump-tools with ffmpeg and a fancier cmdline tool https://github.com/shellixyz/hd_fpv_video_tool and a few others that I can't find links for immediately.

The reason we went for WebCodecs despite it being a bit of a clusterf*ck in more way than one was to have GPU acceleration in the browser.

I'm not sure if that's what you were proposing, but there's not enough grunt on the goggles to add the osd natively.