fpvout / DigiView-Android

Live video out from your DJI FPV Goggles via USB.
https://fpvout.com
MIT License
281 stars 61 forks source link

Add watermark / button to bottom left of the screen #18

Closed D3VL-Jack closed 3 years ago

D3VL-Jack commented 3 years ago

Add a watermark to the bottom right corner of the screen as discussed in dev-chat. Ideally this would act as a button for the menu of the app, and should be removable by the user if desired.

Assets attached -> digiview-feed-overlays.zip I've added images with and without the text as this may want to be localized in the future.

examples: digiview feed#1 digiview feed#5

squshy7 commented 3 years ago

@Jack-Rogers just to follow up on my previous suggestion about making it act as a settings button, I was definitely serious about the idea, but it would also be good practice to provide the standard hamburger/3 dots (up for debate which) as well. the watermark being settings is a neat easter egg (at least that was my original vision when I suggested it).

D3VL-Jack commented 3 years ago

You're probably right! from a UX point of view, people know what 3 lines means, but less so that they have to click the logo!

Maybe hamburger top left that hides after 10 seconds if there's no user input and the video is streaming, then If the video stops streaming bring it back into view, and also bring it back if the user touches the screen?

richardbulger commented 3 years ago

I personally would rather the video had no overlay at all when viewing it. It's distracting and unaesthetic. Controls/menu button could be shown on tapping the video

fichek commented 3 years ago

I personally would rather the video had no overlay at all when viewing it. It's distracting and unaesthetic. Controls/menu button could be shown on tapping the video

There has to be a bit of branding by default + it's sort of a parody on how Smart Controller does it ;) but will make it easy to remove.

jlucidar commented 3 years ago

it's been merged ! thanks @fichek :)