Thank you for avitab! I tried to build it myself on my MacBook running macOS Ventura 13.4.1 using cmake. It failed due to compilation errors. My c++ is a bit rusty, but the errors made sense to me and I offer you a fix that made it compile again.
Errors:
/Users/matteo/Developer/avitab/src/libxdata/XWorld.h:48:10: error: 'visitNodes' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
void visitNodes(const world::Location &upLeft, const world::Location &lowRight, NodeAcceptor f);
^
/Users/matteo/Developer/avitab/src/world/World.h:49:18: note: overridden virtual function is here
virtual void visitNodes(const world::Location &upLeft, const world::Location &lowRight, NodeAcceptor f) = 0;
/Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__memory/shared_ptr.h:311:9: error: destructor called on non-final 'xdata::XWorld' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
__get_elem()->~_Tp();
Hi,
Thank you for avitab! I tried to build it myself on my MacBook running macOS Ventura 13.4.1 using cmake. It failed due to compilation errors. My c++ is a bit rusty, but the errors made sense to me and I offer you a fix that made it compile again.
Errors:
/Users/matteo/Developer/avitab/src/libxdata/XWorld.h:48:10: error: 'visitNodes' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] void visitNodes(const world::Location &upLeft, const world::Location &lowRight, NodeAcceptor f); ^ /Users/matteo/Developer/avitab/src/world/World.h:49:18: note: overridden virtual function is here virtual void visitNodes(const world::Location &upLeft, const world::Location &lowRight, NodeAcceptor f) = 0;
/Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__memory/shared_ptr.h:311:9: error: destructor called on non-final 'xdata::XWorld' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor] __get_elem()->~_Tp();
Best regards, Matteo Frankfurt/Germany