cyberang3l
commented
11 months ago @fpw I see that making different PRs doesn't help too much, as everything is rebased on top of master?
Anyway, the first two are PRs (this: #164 and #166) are usable and ready to land. I would recommend we merge those if you are happy with the changes and continue with the rest of the plan that is described in this PR.
I also made #165 that fixes a random small bug that I found.
Big note: I only test my code on a Linux box, as I don't have access to a Windows machine. It should work, but please verify if you are on windows.
This is first PR in a series of (likely 3 or 4) PRs that I'm planning to do to introduce configurable online slippy maps via a json configuration.
Please do not merge this yet, but start reviewing the code :)
Let me finish with all the PRs and we can the merge them together.
The plan is: PR 1 (this): introduce basic components for adding a new clickable and configurable list
PR 2: Introduce the map configuration format and the actual feature with a sample map (default OpenStreetMap) as part of the default json configuration - not all the functionality of the configuration is here yet (#166)
PR 3: Make changes to the base OpenTopoSource class to support all the configuration parameters introduced by PR 2
PR 4: Move Stamen terrain (is this even working? Doesn't work for me) and OpenTopoMaps under the new Online Maps button?
PR 5: I'll add the .clang-config that I used to format the newly added files for reference. It doesn't hurt to have the config in the repo; as long as you don't use clang-format explicitly to format a file it does nothing. We can make adjustments to the clang-config and you can use it to format other files in the future too if you want.