search

fpw / avitab

X-Plane plugin that displays a tablet to aid VR usage
GNU Affero General Public License v3.0
299 stars 58 forks source link

Visual menu feedback about the enabled online map #172

Closed cyberang3l closed 10 months ago

cyberang3l commented 10 months ago

The "Online" maps button brings up a menu and allows you to select from one or more maps. With this commit we store the name of the selected online map when successfully applied, and show the name of the selected map in the onlineMapsLabel next time the user clicks on the button that shows the map settings menu.

Peek 2023-11-12 18-40

mjh65 commented 10 months ago

Not a comment on this PR specifically, but just to note that an earlier PR has introduced a compile error on Windows. See https://github.com/fpw/avitab/issues/171 for details.

I'm investigating a fix.

fpw commented 10 months ago

I'm investigating a fix.

Fixed. u8path should only be used to pass the result to stream constructors, not to messages. Reason is that it has different types on different platforms. It's a wchar_t on Windows and char on others.

Its purpose is basically "given this UTF-8 path, convert it to whatever type the platform uses natively for paths". Strings can directly use UTF-8 since LVGL is UTF-8 aware.

cyberang3l commented 10 months ago

Thanks both and sorry for the inconvenience, but I don't have a windows machine to test it on windows.