fpw / avitab

X-Plane plugin that displays a tablet to aid VR usage
GNU Affero General Public License v3.0
299 stars 58 forks source link

Flight plan overlay phase 3 - procedures #192

Closed dave6502 closed 6 months ago

dave6502 commented 7 months ago

This adds functionality to decompose into waypoints any SIDs, STARs and Approaches named in the FMS. The waypoints for procedures are not present in the FMS - just the name, so the NavData database is queried to get them.

Note that

As a result of the above, code to attempt to linearly trace through waypoints (similar to the iterate method) was perceived as becoming an unreadable, bug-prone mess of multidimensional if/then statements. So the approach (no pun intended) here is to loop through all possible permutations of concatenated segments and check whether the permutation meets the constraints of the (possibly don't care) runway and transition in the FMS. This provides a more complete version of common waypoints and the code has a much cleaner flow.

mjh65 commented 6 months ago

This PR has now fallen behind #193, which has a small bug fix for Mac builds and 2 additional refactoring updates.

fpw commented 6 months ago

Merged via #193