fpw / avitab

X-Plane plugin that displays a tablet to aid VR usage
GNU Affero General Public License v3.0
299 stars 58 forks source link

Bug fixes #210

Closed dave6502 closed 1 month ago

dave6502 commented 2 months ago

3 bug fixes, which have come to light after 0.6.4 release There is a small amount of overlap with files changed in https://github.com/fpw/avitab/pull/209, but I can resubmit if required.

fpw commented 1 month ago

Thanks for the fixes! There's a tiny merge conflict now after merging #209, it would be great if you could fix that, then I'll merge immediately.

mjh65 commented 1 month ago

I've resolved the merge conflict - github has updated the source branch in @dave6502's fork. @dave6502, could you do a quick build and sanity check and verify that I resolved the conflict correctly. Thanks!

mjh65 commented 1 month ago

@dave6502, one other thing to be aware of. Before rebuilding Avitab you'll need to update the git submodules as one of the recently added PRs updates the curl libraries to a recent version. I would also recommend to clean and build the 3rd-party libraries, as I have found that some are not very tolerant to a rebuild on top of a previous build.