search

fqborges / react-native-maps-osmdroid

React Native Mapview component for iOS + Android
MIT License
67 stars 22 forks source link

Upgrade to react-native-maps 0.25.0 #11

Closed cormander closed 4 years ago

cormander commented 4 years ago

This pulls in the latest code from react-native-maps per my comments in https://github.com/react-native-community/react-native-maps/pull/2348. Figured I'd send it along so you could have a look and see if we could help each other out.

fqborges commented 4 years ago

Thanks man.

I have no time to inspect and test this merge now, but I am sure you already did it. Would you like me to publish a version right now? It seems to be past the last published release, so maybe we can wait to merge in a release and publish a version based on it.

Sure we can help each other, but I will be more reactive now, so please let me know when you need anything. I hope in the next weeks I can actively work on the issues you stated, like the callout crashes an memory leaks.

cormander commented 4 years ago

Thanks! Don’t push yet - there are some issues surrounding the RN 0.60+ that the upstream still has some PRs on. Will wait on their next release and am willing to wait on that. Also in looking this over again I missed a few things like on the README. I’ll likely open another PR to fix things like that this weekend if you don’t have the time this week.

I’d really like to get this into a state where it can merge upstream. Just let me know your availability moving into Q4. Thanks,

cormander commented 4 years ago

They just pushed 0.26.0 with the RN 0.60+ stuff. I'll work on another PR to pull those in and do any fixes I manage to come up with along the way and send it this weekend.