search

fr1kin / ForgeHax

A Minecraft cheat that runs as a Forge mod
MIT License
486 stars 128 forks source link

Update mappings #115

Closed LoganDark closed 5 years ago

LoganDark commented 5 years ago

You're using MCP mappings from 2017. stable_39 is the latest 1.12.2 mapping. It's a lot newer and also marked stable.

Curious to hear why you're staying on these old mappings, as I'm sure you have a good reason

fr1kin commented 5 years ago

Curious to hear why you're staying on these old mappings, as I'm sure you have a good reason

"If its not broke don't fix it"

LoganDark commented 5 years ago

If I created a PR for this, then would you merge it? I'm in the process of getting ForgeHax set up as a project locally, so I can work on these things.

fr1kin commented 5 years ago

If you verify it works in production

LoganDark commented 5 years ago

Yes, I will. Jenkins builds it automatically so when I make the PR I will check.

What versions is ForgeHax supposed to support? so I can test in all of them

fr1kin commented 5 years ago

I use 1.12.2-14.23.5.2775. I think newer versions of forge don't work with forgehax, but I don't remember.

LoganDark commented 5 years ago

2838 here, the latest recommended. Good to know you don't support 1.13+, since it's an absolute fucking nightmare and Lex is obsessed with his fancy new toolchain that decompiles Minecraft every time you open your IDE.

Of course, thanks to all the developers that cried wolf in the past, he doesn't listen when people try to tell him it sucks.

Rant over, sorry, that was off topic.

fr1kin commented 5 years ago

Technically forgehax does have a 1.13.2 build. @babbaj maintains it (somewhat) so that when 2b2t updates to 1.13 we will be ready.

LoganDark commented 5 years ago

Well, that's their problem then. This probably won't affect them, correct me if I'm wrong.

LoganDark commented 5 years ago

So, I kind of stuck a Forge MDK in the ForgeHax directory to see if it would work. Clearly it didn't. While on the topic of mappings, since my build fails trying to find http://export.mcpbot.bspk.rs/mcp/@forgehax.mcp.version@/mcp-@forgehax.mcp.version@-srg.zip (which I know is an formatting error), exactly what build system am I supposed to use for this, if not ForgeGradle?

fr1kin commented 5 years ago

Yeah this is some dumb issue caused because the gradle build doesn't apply the tokens to config.properties. A simple fix is to run gradle build, then find the conf.properties in the build/resources directory and copy/replace it to out/production/.../resources/config.properties

LoganDark commented 5 years ago

Aw fuck, it was that issue you outlined in the FAQ. You should specify which exception that causes...

fr1kin commented 5 years ago

Sorry about that. It's a really weird bug because sometimes it works, but other times it doesn't. In another project of mine, I wrote something that manually applies the tokens to config.properties if it detects its running in an IDE.

LoganDark commented 5 years ago

Well another weird bug is that after doing all sorts of weird stuff to try to get IntelliJ to load the project properly, ForgeHax ASM loads but not ForgeHax itself.

image

Do you have a Discord so we could talk there instead of over GitHub issues? since this is getting a little off topic

fr1kin commented 5 years ago

fr1kin#8565, but I don't have discord open very often. If I don't respond its probably because discord is closed, and you can reach me on matrix by @fr1kin:nerdsin.space

fr1kin commented 5 years ago

I use the latest forge 1.12.2 release now, but I kept the mappings the same as forge hasn't updated them either. Just gonna keep it at that.