search

fr3ts0n / AndrOBD

Android OBD diagnostics with any ELM327 adapter
http://fr3ts0n.github.io/AndrOBD/
GNU General Public License v3.0
1.45k stars 310 forks source link

RPM Limit to 6000 to 12000 #190

Closed CodingAliceX closed 2 years ago

CodingAliceX commented 2 years ago

For most motorcycle engines

fr3ts0n commented 2 years ago

Thank you for you PR.

I see 2 potential issues with this change:

  1. Class is NOT in use for AndrOBD
    • It's part of the generic java library and used for some swing progs only
    • The pendent to this in AndrOBD is EcuConversions, which is driven by a CSV data file
  2. Ranges are customizable by user in AndrOBD at runtime.
    • Since V2.5.x display ranges may be customized by the user (see Wiki ) (see Release notes )