search

fr3ts0n / AndrOBD

Android OBD diagnostics with any ELM327 adapter
http://fr3ts0n.github.io/AndrOBD/
GNU General Public License v3.0
1.45k stars 310 forks source link

Flashlight toggle inside the app #277

Open aha999 opened 2 months ago

aha999 commented 2 months ago

Is your feature request related to a problem? Please describe. When doing car diagnostics, users in my opinion tend to use their phone's flashlight a lot, so currently the users have to exit the app and launch the flashlight outside the app.

Describe the solution you'd like It would be really useful if users of AndrOBD had a flashlight toggle button inside the app, that would activate the phone's flashlight, therefore aid a lot in finding the OBD port in the dark spot, and whereever the flashlight comes in handy when doing car diagnostics.

Additional context This would be helpful cool feature that users would probably appreciate, myself included.

fr3ts0n commented 2 months ago

Sorry, but I don't think this is a big improvement. At least on all the phones I use, I can set a hardware key/button to toggle the flash light. This is way more flexible and valid for any app running ...

ieffuie4 commented 2 months ago

I also vote against this. On modern phones you just put the finger on top of the screen while running AndrOBD, pull down the buttons and press flashlight toggle. This works on nearly all android apps that do not fully force fully screen mode and even there it often works. It would be full waste of dev-time to add such a thing.