fra31 / auto-attack

Code relative to "Reliable evaluation of adversarial robustness with an ensemble of diverse parameter-free attacks"
https://arxiv.org/abs/2003.01690
MIT License
639 stars 111 forks source link

Bug Fix | FAB attack targetted version inable to reach #91

Closed HengyueL closed 2 years ago

HengyueL commented 2 years ago

Original autoattack code cannot use FAB-targetted version because of the following code bug.

fra31 commented 2 years ago

Hi,

thanks for the contribution! I agree that the proposed change makes it more precise, but when using AA the targeted version is set, after initialization, here, which should be sufficient, what do you think?

HengyueL commented 2 years ago

Yes that will be sufficient if users call autoattack directly, but could potentially provide hazard if user want to benchmark with one particular method (i.e, FAB here) if user call the FAB class and provide their own hyperparameters (like how i notice this myself :) )