Closed HengyueL closed 2 years ago
Hi,
thanks for the contribution! I agree that the proposed change makes it more precise, but when using AA the targeted version is set, after initialization, here, which should be sufficient, what do you think?
Yes that will be sufficient if users call autoattack directly, but could potentially provide hazard if user want to benchmark with one particular method (i.e, FAB here) if user call the FAB class and provide their own hyperparameters (like how i notice this myself :) )
Original autoattack code cannot use FAB-targetted version because of the following code bug.